chore: migration to vite+ #5709

fengmk2 · 2025-11-28T08:21:39Z

┌  Vite+ Migration
│
◇  [email protected] installed
│
◇  Dependencies installed
│
◆  ✅ Rewrote import in vitest.config.ts
│
◆  ✅ Created vite.config.ts in vite.config.ts
│
◆  ✅ Merged .oxlintrc.json into vite.config.ts
│
◆  ✅ Merged .oxfmtrc.json into vite.config.ts
│
◆  ✅ Rewrote import in packages/utils/vitest.config.ts
│
◆  ✅ Rewrote import in packages/tsconfig/vitest.config.ts
│
◆  ✅ Rewrote import in packages/supertest/vitest.config.ts
│
◆  ✅ Rewrote import in packages/router/vitest.config.ts
│
◆  ✅ Rewrote import in packages/path-matching/vitest.config.ts
│
◆  ✅ Rewrote import in packages/koa-static-cache/vitest.config.ts
│
◆  ✅ Rewrote import in packages/koa/vitest.config.ts
│
◆  ✅ Rewrote import in packages/extend2/vitest.config.ts
│
◆  ✅ Rewrote import in packages/errors/vitest.config.ts
│
◆  ✅ Rewrote import in packages/egg/vitest.config.ts
│
◆  ✅ Rewrote import in packages/core/vitest.config.ts
│
◆  ✅ Rewrote import in packages/cookies/vitest.config.ts
│
◆  ✅ Rewrote import in packages/cluster/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/watcher/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/view-nunjucks/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/view/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/typebox-validate/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/tracer/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/static/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/session/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/security/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/schedule/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/redis/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/onerror/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/multipart/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/mock/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/logrotator/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/jsonp/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/i18n/vitest.config.ts
│
◆  ✅ Rewrote import in plugins/development/vitest.config.ts
│
◆  ✅ Rewrote import in examples/helloworld-typescript/vitest.config.ts
│
◆  ✅ Rewrote import in examples/helloworld-tegg/vitest.config.ts
│
◆  ✅ Rewrote import in tools/scripts/vitest.config.ts
│
◆  ✅ Rewrote import in tools/create-egg/vitest.config.ts
│
◆  ✅ Rewrote import in tegg/plugin/controller/vitest.config.ts
│
◇  Dependencies installed
│
└  ✨ Migration completed!

coderabbitai · 2025-11-28T08:21:48Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch vite-plus-migration4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · 2025-11-28T08:22:24Z

Deploying egg with Cloudflare Pages

Latest commit:	`7bc852c`
Status:	🚫 Build failed.

View logs

cloudflare-workers-and-pages · 2025-11-28T08:23:11Z

Deploying egg-v3 with Cloudflare Pages

Latest commit:	`7bc852c`
Status:	🚫 Build failed.

View logs

Copilot

Pull request overview

This PR migrates the Eggjs monorepo from oxlint/oxfmt tooling to vite+ (a custom tooling suite from VoidZero). The migration consolidates linting, formatting, and testing under a unified vite-based toolchain.

Key Changes:

Replaces oxlint/oxfmt with vite+ commands across all packages and scripts
Migrates vitest to @voidzero-dev/vite-plus-test package alias
Introduces centralized vite.config.ts for format and lint configuration
Adds GitHub package registry authentication for @voidzero-dev packages

Reviewed changes

Copilot reviewed 42 out of 43 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
vite.config.ts	New centralized configuration file migrating settings from .oxlintrc.json and .oxfmtrc.json
pnpm-workspace.yaml	Updates catalog to replace oxlint/oxfmt with vite+ packages; adds peer dependency rules and overrides
.npmrc	Configures GitHub package registry authentication for @voidzero-dev scoped packages
package.json (root)	Updates scripts to use vite commands; replaces oxlint/oxfmt devDependencies with @voidzero-dev/vite-plus
.oxlintrc.json	Removed - configuration migrated to vite.config.ts
.oxfmtrc.json	Removed - configuration migrated to vite.config.ts
packages/*/package.json	Updates lint/test scripts from oxlint/vitest to vite lint/vite test; removes oxlint devDependencies
plugins/*/package.json	Updates lint/test scripts from oxlint/vitest to vite lint/vite test; removes oxlint devDependencies
tools/*/package.json	Updates lint/test scripts from oxlint/vitest to vite lint/vite test; removes oxlint devDependencies
examples/*/package.json	Updates test scripts from vitest to vite test; updates lint commands in some examples

Copilot · 2025-11-28T08:25:41Z

pnpm-workspace.yaml

+  vite: 'catalog:'
+  vitest: 'catalog:'


The overrides section now forces both vite and vitest to use the catalog versions (which are aliased to @voidzero-dev packages). This is a significant change from the previous rolldown-vite@^7.1.13 override. Ensure that:

All packages that depend on vite/vitest are compatible with the vite+ versions

This doesn't break any existing functionality that relied on the rolldown-vite fork

The change is intentional and has been tested across all workspace packages

This is a critical override that affects the entire monorepo's build and test infrastructure.

Copilot · 2025-11-28T08:25:42Z

.npmrc

+//npm.pkg.github.com/:_authToken=${GITHUB_TOKEN}
+@voidzero-dev:registry=https://npm.pkg.github.com/


The GitHub token is being referenced via environment variable ${GITHUB_TOKEN}, but there's no validation or fallback if this variable is not set. This could cause silent failures during package installation. Consider:

Documenting this requirement in README or CONTRIBUTING.md

Adding validation in CI/CD pipelines to ensure GITHUB_TOKEN is set

Providing clear error messages when the token is missing

Additionally, ensure this token has appropriate read permissions for the @voidzero-dev scope packages.

Copilot · 2025-11-28T08:25:42Z

pnpm-workspace.yaml

+peerDependencyRules:
+  allowAny:
+    - vite
+    - vitest
+  allowedVersions:
+    vite: '*'
+    vitest: '*'


The peerDependencyRules configuration uses allowAny and allowedVersions: '*' for both vite and vitest. This effectively disables peer dependency version checking, which could lead to compatibility issues. While this may be necessary for the vite+ migration, consider:

Whether this is a temporary workaround or permanent solution

Adding documentation explaining why these broad permissions are needed

Testing thoroughly to ensure no breaking changes occur from version mismatches

This configuration makes the build less strict and could hide incompatibility issues.

Copilot · 2025-11-28T08:25:42Z

pnpm-workspace.yaml

  - oxlint-tsgolint
  - oxlint
  - oxc-minify
+  - '@voidzero-dev/*'


The minimumReleaseAgeExclude list still references oxlint-tsgolint, oxlint, and oxc-minify (lines 240-242), but these packages have been removed from the catalog and are no longer used in the project. While adding @voidzero-dev/* to the exclusion list is correct, consider also removing the obsolete oxlint-related entries to keep the configuration clean and up-to-date.

codecov · 2025-11-28T16:21:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.74%. Comparing base (c33e4f1) to head (7bc852c).
⚠️ Report is 2 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #5709      +/-   ##
==========================================
+ Coverage   87.40%   90.74%   +3.33%     
==========================================
  Files         561        6     -555     
  Lines       10932       54   -10878     
  Branches     1238       12    -1226     
==========================================
- Hits         9555       49    -9506     
+ Misses       1293        5    -1288     
+ Partials       84        0      -84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

socket-security · 2025-12-04T09:49:21Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@types/mocha@10.0.10
	ajv-formats@2.1.1

View full report

Copilot

Pull request overview

Copilot reviewed 79 out of 80 changed files in this pull request and generated 12 comments.

Copilot · 2025-12-04T09:57:05Z

packages/core/package.json

+    "lint": "vite lint",
    "typecheck": "tsc --noEmit",
-    "test": "vitest run",
+    "test": "vite test run",


The scripts use vite lint and vite test run commands, but @voidzero-dev/vite-plus is missing from devDependencies. Add it to ensure the commands work.

Copilot · 2025-12-04T09:57:06Z

packages/utils/package.json

+    "lint": "vite lint --type-aware",
    "typecheck": "tsc --noEmit",
-    "test": "vitest run",
+    "test": "vite test run",


The scripts use vite lint and vite test run commands, but @voidzero-dev/vite-plus is missing from devDependencies. Add it to ensure the commands work.

Copilot · 2025-12-04T09:57:06Z

tools/egg-bin/package.json

  },
  "scripts": {
-    "lint": "oxlint --type-aware",
+    "lint": "vite lint --type-aware",


The lint script uses vite lint command, but @voidzero-dev/vite-plus is missing from devDependencies. Add it to ensure the command works.

Copilot · 2025-12-04T09:57:06Z

plugins/mock/package.json

+    "lint": "vite lint",
    "typecheck": "tsc --noEmit",
-    "test": "vitest run",
+    "test": "vite test run",


The scripts use vite lint and vite test run commands, but @voidzero-dev/vite-plus is missing from devDependencies. Add it to ensure the commands work.

Copilot · 2025-12-04T09:57:06Z

.npmrc

+@voidzero-dev:registry=https://npm.pkg.github.com/
+//npm.pkg.github.com/:_authToken=${VP_TOKEN}


The .npmrc file configures authentication for GitHub Packages using an environment variable VP_TOKEN. Ensure this token is properly documented and secured. Consider adding a comment in this file explaining what this token is for and where to obtain it, or reference documentation that explains this.

Copilot · 2025-12-04T09:57:07Z

packages/koa/package.json

+    "lint": "vite lint --type-aware",
+    "test": "vite test run",


The scripts use vite lint and vite test run commands, but @voidzero-dev/vite-plus is missing from devDependencies. Add it to ensure the commands work.

Copilot · 2025-12-04T09:57:08Z

plugins/development/package.json

+    "lint": "vite lint --type-aware",
    "typecheck": "tsc --noEmit",
-    "test": "vitest run",
+    "test": "vite test run",


The scripts use vite lint and vite test run commands, but @voidzero-dev/vite-plus is missing from devDependencies. Add it to ensure the commands work.

Copilot · 2025-12-04T09:57:08Z

pnpm-workspace.yaml

  xss: ^1.0.15
  ylru: ^2.0.0
  zod: ^3.24.1
+  vite: npm:@voidzero-dev/vite-plus-core@latest


The vite catalog entry is aliasing to @voidzero-dev/vite-plus-core@latest which appears to be a different package. This override may break any packages that depend on the standard vite package. Consider whether this alias is necessary or if vite-plus should be used independently.

Copilot · 2025-12-04T09:57:08Z

pnpm-workspace.yaml

  on-finished: ^2.4.1
  onelogger: ^1.0.1
  oxc-minify: ^0.99.0


The oxfmt, oxlint, and oxlint-tsgolint dependencies have been removed from the catalog, but there are still references to oxlint in documentation files (AGENTS.md, CLAUDE.md, .github/copilot-instructions.md, and others). These documentation files should be updated to reflect the migration to vite-plus tooling.

Copilot · 2025-12-04T09:57:08Z

.github/workflows/ci.yml

  id-token: write
  actions: write

+env:


The VP_TOKEN environment variable is added for GitHub Packages authentication to access @voidzero-dev packages. Consider adding a comment or documentation in the workflow explaining what this token is for and how to set it up for contributors, as this is a new external dependency requirement.

Suggested change

env:

env:

# VP_TOKEN is required for authenticating with GitHub Packages to access @voidzero-dev packages.

# Contributors: Set the VP_TOKEN secret in your repository or organization settings with a valid GitHub Packages token.

# See CONTRIBUTING.md for setup instructions.

fengmk2 requested a review from Copilot November 28, 2025 08:21

Copilot started reviewing on behalf of fengmk2 November 28, 2025 08:22 View session

Copilot finished reviewing on behalf of fengmk2 November 28, 2025 08:24

Copilot AI reviewed Nov 28, 2025

View reviewed changes

fengmk2 force-pushed the vite-plus-migration4 branch from b55ec07 to 38adb66 Compare November 28, 2025 08:33

chore: vite+ migration

b66932f

fengmk2 force-pushed the vite-plus-migration4 branch from 32730ce to b66932f Compare December 4, 2025 09:47

fengmk2 requested a review from Copilot December 4, 2025 09:47

Copilot started reviewing on behalf of fengmk2 December 4, 2025 09:50 View session

Copilot finished reviewing on behalf of fengmk2 December 4, 2025 09:54

Copilot AI reviewed Dec 4, 2025

View reviewed changes

FIXUP

7bc852c

		//npm.pkg.github.com/:_authToken=${GITHUB_TOKEN}
		@voidzero-dev:registry=https://npm.pkg.github.com/

		@voidzero-dev:registry=https://npm.pkg.github.com/
		//npm.pkg.github.com/:_authToken=${VP_TOKEN} No newline at end of file

-env:
+env:
+  # VP_TOKEN is required for authenticating with GitHub Packages to access @voidzero-dev packages.
+  # Contributors: Set the VP_TOKEN secret in your repository or organization settings with a valid GitHub Packages token.
+  # See CONTRIBUTING.md for setup instructions.

Uh oh!

chore: migration to vite+ #5709

Are you sure you want to change the base?

chore: migration to vite+ #5709

Uh oh!

Conversation

fengmk2 commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

cloudflare-workers-and-pages bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying egg with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying egg-v3 with Cloudflare Pages

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

socket-security bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

fengmk2 commented Nov 28, 2025 •

edited

Loading

coderabbitai bot commented Nov 28, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Nov 28, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Nov 28, 2025 •

edited

Loading

codecov bot commented Nov 28, 2025 •

edited

Loading

socket-security bot commented Dec 4, 2025 •

edited

Loading